ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
78 stars 34 forks source link

Issue 373, v3: Upgrade rdf-toolkit and Java #398

Closed ajnelson-nist closed 2 years ago

ajnelson-nist commented 2 years ago

This Pull Request supersedes PR 395. It is a rebase of the patches in that PR against the beginning of the develop branch immediately after UCO 0.8.0's release. The reason for rebasing to earlier in develop is so effects can be isolated for CASE to adopt in CASE PR 90. There is otherwise no change from the "v2" of this PR.

This PR will resolve all requirements of Issue 373.

Review steps taken:

ajnelson-nist commented 2 years ago

The only impact this proposal has on generated CASE files is that the "nightly build" ontology files now are normalized according to rdf-toolkit 1.11.0. (Both CASE-develop.ttl and CASE-unstable.ttl must be generated by the same rdf-toolkit version.) This is only a light oddity in normalization for the next week, and should not negative impact users.

sbarnum commented 2 years ago

The CP that this PR is targeted to address describes and proposes changes only to the normalization tool chain outside of the ontology, however this PR contains several substantive changes to the ontology itself in the form of redefinition of all enumerations in the observable.ttl namespace. I assume these changes were included by error and are associated with some other CP? These changes should be removed from the PR before it is voted and approved.

ajnelson-nist commented 2 years ago

@sbarnum Those changes are not redefinitions. They are syntactic-sugar adjustments, with no semantic revision. The new version of rdf-toolkit (1.11.0) catches those as syntax to normalize. It's not clear why 1.10.0 didn't.