search

ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
76 stars 34 forks source link

FileFacet has inconsistent property name pattern for timestamps #420

Open eoghanscasey opened 2 years ago

eoghanscasey commented 2 years ago

Bug description

The FileFacet has inconsistent property name pattern for timestamps, with observableCreatedTime versus accessedTime and modifiedTime.

Steps to reproduce

Need to update property names to observableAccessedTime and observableModifiedTime.

ajnelson-nist commented 2 years ago

@eoghanscasey : I've flagged this as a 2.0.0 issue, but if we get a proposal to reconcile the names today, we could discuss next week whether this is a Fast Track change for 1.0.0. I do think the burden for fast-track changing names around is pretty high on the "Gracefulness of the suggestion" factor.

eoghanscasey commented 2 years ago

This change is cosmetic rather than breaking and can wait for a champion, if any. Changing these property names would impact additional facets including, AccountFacet, BrowserBookmarkFacet, BrowserCookieFacet, CalendarEntryFacet, EmailMessageFacet, and NoteFacet.

ajnelson-nist commented 2 years ago

Unfortunately, a property name change is relevant for backwards compatibility. We either fix the inconsistent name pattern that was rushed through now, or we wait until 2.0.0.