ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
76 stars 34 forks source link

Cut errant rdf:List artifact #456

Closed ajnelson-nist closed 2 years ago

ajnelson-nist commented 2 years ago

This Pull Request is a cleanup to side effects from what is currently suspected to have come from either Issue #406 , from an unrealized effect in the release of rdflib 6.2.0, or both. The submitter believes risk from adoption, to UCO and downstream ontologies, is zero.

Somewhere in the chain between core rdflib, pyshacl, and rdf-toolkit.jar, the normalized Turtle content sometimes picks up redundant rdf:List artifacts that vary between runs. The anonymous list cut in this patch has been seen to waver in how much of it is left as a detached blank node, here and in other CASE examples.

The first patch in this PR removes the orphaned list. Guidance needs to be provided that, as long as this bug in the tool stack persists, the Make-managed generated output should not have it Git-tracked.

Review steps taken:

ajnelson-nist commented 2 years ago

I am aware this can potentially cause some merge conflicts for incoming proposals to UCO's develop branch. However, those conflicts will be on whether these errant, orphan rdf:List entries should exist, and to what degree, which I hope we agree justifies keeping them out of the generated results.