Issue 428: Remove sh:minCounts to support minimal object definitions

ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.

Apache License 2.0

76 stars 34 forks source link

Issue 428: Remove sh:minCounts to support minimal object definitions #460

Closed ajnelson-nist closed 2 years ago

ajnelson-nist commented 2 years ago

This Pull Request resolves all requirements of Issue #428 .

Review steps taken:

[x] Pull request is against correct branch
[x] CI passes in (CASE/UCO) feature branch
[x] CI passes in (CASE/UCO) current unstable branch (49568da)
[x] Impact on SHACL validation reviewed for CASE-Examples
[x] Impact on SHACL validation remediated for CASE-Examples (N/A)
[x] Impact on SHACL validation reviewed for casework.github.io
[x] Impact on SHACL validation remediated for casework.github.io (N/A)

ajnelson-nist commented 2 years ago

@eoghanscasey , fyi: I did not apply the observable:message change in MessageThreadFacet because by the time this branch was started, observable:message no longer existed. It was removed as part of #393 .

ajnelson-nist commented 2 years ago

Also, the ConfigurationSettingType tool:itemValue min. count removal will end up being mooted by Issue #405 and/or Issue #432 . There was a merge conflict for tool.ttl in the unstable branch about this.