search

ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
79 stars 34 forks source link

MyPy Fixes #478

Closed kchason closed 2 years ago

kchason commented 2 years ago

Addresses errors so that mypy [--strict] can run against the tests/ directory.

ajnelson-nist commented 2 years ago

The pytest annotation bit may be related to this Issue.

ajnelson-nist commented 2 years ago

Thanks, @kchason , for fielding this issue.

For everyone else's background, the case-utils repo has had to ignore a type error I'd accidentally made in the UCO pytest script. I didn't catch it until implementing mypy in case-utils, and left a TODO here (today's state) due to needing to focus on something else at the moment.

Because this is a change solely to a Python script, and further to artifacts that don't have a runtime effect (unless symbol references are broken), I am considering this a bugfix proposal.

I'm going to wait for CI to pass, and then will merge this.