ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.

Apache License 2.0

79 stars 34 forks source link

Bug fix 513 #514

Closed b0bkaT closed 1 year ago

b0bkaT commented 1 year ago

This Pull Request resolves all requirements of Issue #513 .

Coordination

[x] Pull Request is against correct branch
[x] Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
[x] CI passes in UCO feature branch against develop
[x] CI passes in UCO current unstable branch (b22d045)
[x] CI passes in CASE current unstable branch tracking UCO's unstable as submodule (18fe007)
[x] Impact on SHACL validation reviewed for CASE-Examples
[x] Impact on SHACL validation remediated for CASE-Examples (N/A)
[x] Impact on SHACL validation reviewed for casework.github.io
[x] Impact on SHACL validation remediated for casework.github.io (N/A)
[x] Milestone linked
[x] Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status) (N/A, bugfix)

ajnelson-nist commented 1 year ago

@DrSnowbird , could you please test out this PR and see if it resolves Issue 513? For some reason, I can't request you as a reviewer.

DrSnowbird commented 1 year ago

Alex,I will test it this afternoon - just so many piling-up tasks.v/r Ray On Friday, January 13, 2023 at 03:13:16 PM EST, Alex Nelson @.***> wrote:

@DrSnowbird , could you please test out this PR and see if it resolves Issue 513? For some reason, I can't request you as a reviewer.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

DrSnowbird commented 1 year ago

Hi Alex, I just completed the tests and the previous SHACL errors in UCO Shapes are gone. The fix Bug-Fix-153 is good as my review results. The fixed UCO is very good now (no error using my (TopBraid lib to validate). V/R Ray On Friday, January 13, 2023 at 03:30:52 PM EST, Ray Sheu @.***> wrote:

Alex,I will test it this afternoon - just so many piling-up tasks.v/r Ray On Friday, January 13, 2023 at 03:13:16 PM EST, Alex Nelson @.***> wrote:

@DrSnowbird , could you please test out this PR and see if it resolves Issue 513? For some reason, I can't request you as a reviewer.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

ajnelson-nist commented 1 year ago

@DrSnowbird Wonderful, thank you! We'll have this in the next release.