ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.

Apache License 2.0

73 stars 34 forks source link

Issue 541: Add Event #542

Closed sbarnum closed 7 months ago

sbarnum commented 11 months ago

This Pull Request resolves all requirements of Issue #541 .

Coordination

[x] Pull Request is against correct branch
[x] Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
[x] CI passes in UCO feature branch against develop
[x] CI passes in UCO current unstable branch (fd8e56c)
[x] CI passes in CASE current unstable branch tracking UCO's unstable as submodule (7adb16d)
[x] Impact on SHACL validation reviewed for CASE-Examples
[x] Impact on SHACL validation remediated for CASE-Examples (N/A)
[x] Impact on SHACL validation reviewed for casework.github.io
[x] Impact on SHACL validation remediated for casework.github.io (N/A)
[x] Milestone linked
[x] Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

ajnelson-nist commented 11 months ago

This should have targeted develop; I'm editing the PR now to re-target.

ajnelson-nist commented 11 months ago

@sbarnum , FYI - To prevent premature merges, PRs are left in Draft form until the passing Solutions Approval vote is logged.

sbarnum commented 11 months ago

This should have targeted develop; I'm editing the PR now to re-target.

Hmm. I definitely chose 'develop' as the target as I had to change it from the default of 'master'. Not sure what happened. Thanks for fixing.

sbarnum commented 11 months ago

I interpret an Event as something that expands and/or develops over time, a Perdurant. Furthermore, in the definition of the UcoObject I cannot find any reference to something that is not an Endurant.

In this interpretation we do realize, don't we, that by subclassing the Event from the UcoObject we cannot make a distinction anymore between Endurants and Perdurants, let alone make them disjoint?! In my professional opinion, such distinction is a necessary feature for an interoperability standard to provide.

As the ontologist in CDO, I don't approve of this design.

A simple resolution would be to subclass the Event from the UcoThing, like the UcoObject and UcoInherentCharacterizationThing, and make those three disjoint from each other.

To honor Alex's request to keep this level of discussion on the issue rather than the PR I will wait until Paul moves his comments over to the issue before responding there.

plbt5 commented 11 months ago

To honor Alex's request to keep this level of discussion on the issue rather than the PR I will wait until Paul moves his comments over to the issue before responding there.

Which I did, with appropriate apologies 😊

ajnelson-nist commented 7 months ago

@plbt5 , I am "Dismissing"---using the GitHub interface terminology---your blocking review on this PR, because:

Your feedback in the PR was migrated to this comment.
The feedback spawned the endurants-vs-perdurants proposal, and thus has another spot in UCO's trackers to be discussed and developed.

So, for the sake of this PR, I believe your remarks have been sufficiently addressed. I'm merging the PR now in acknowledgement of the Solutions Approval vote having been logged.