Closed ajnelson-nist closed 10 months ago
@sbarnum , do you have an answer on whether this was a bug?
Absent a reply, this will be discussed in the Ontology Committees meeting on 2023-08-29.
@sbarnum confirmed on today's call - this was an oversight/bug.
I think as a structural change, this would be backwards-incompatible and would need to target UCO 2.0.0.
PR 560 has been posted as a resolution to this confirmed bug.
Note that the implementation had a non-trivial side effect of inducing the Observable namespace to import the Pattern namespace.
Because this was more than adding a subclass designation, I would prefer to handle this as a fast-track change proposal.
PR 560 has been posted as a resolution to this confirmed bug.
Note that the implementation had a non-trivial side effect of inducing the Observable namespace to import the Pattern namespace.
Because this was more than adding a subclass designation, I would prefer to handle this as a fast-track change proposal.
This turned out to not be the case. The transitive import closure for the Observable namespace was not affected; ontology/uco/observable/catalog-v001.xml
already notes that the Pattern namespace is in the transitive import closure.
The impact of this proposal is reduced back to being addition of a single triple, so it is now being treated the bugfix review workflow, for UCO 2.0.0.
Bug description
While reviewing subclasses of
observable:Observable
, I came acrossobservable:ObservablePattern
, which only has one superclass,observable:Observable
.Was this class intended to be a subclass of
pattern:Pattern
?Steps to reproduce
The subclassing statement in UCO 1.2.0 is here.
Coordination
develop
for the next release (N/A)develop
state with backwards-compatible implementation merged intodevelop-2.0.0
(N/A)develop-2.0.0
develop
branch updated to track UCO's updateddevelop
branch (N/A)develop-2.0.0
branch updated to track UCO's updateddevelop-2.0.0
branch