ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
79 stars 34 forks source link

Possible bug - ObservablePattern is not a subclass of Pattern #543

Closed ajnelson-nist closed 10 months ago

ajnelson-nist commented 1 year ago

Bug description

While reviewing subclasses of observable:Observable, I came across observable:ObservablePattern, which only has one superclass, observable:Observable.

Was this class intended to be a subclass of pattern:Pattern?

Steps to reproduce

The subclassing statement in UCO 1.2.0 is here.

Coordination

ajnelson-nist commented 1 year ago

@sbarnum , do you have an answer on whether this was a bug?

Absent a reply, this will be discussed in the Ontology Committees meeting on 2023-08-29.

ajnelson-nist commented 1 year ago

@sbarnum confirmed on today's call - this was an oversight/bug.

ajnelson-nist commented 11 months ago

I think as a structural change, this would be backwards-incompatible and would need to target UCO 2.0.0.

ajnelson-nist commented 10 months ago

PR 560 has been posted as a resolution to this confirmed bug.

Note that the implementation had a non-trivial side effect of inducing the Observable namespace to import the Pattern namespace.

Because this was more than adding a subclass designation, I would prefer to handle this as a fast-track change proposal.

ajnelson-nist commented 10 months ago

PR 560 has been posted as a resolution to this confirmed bug.

Note that the implementation had a non-trivial side effect of inducing the Observable namespace to import the Pattern namespace.

Because this was more than adding a subclass designation, I would prefer to handle this as a fast-track change proposal.

This turned out to not be the case. The transitive import closure for the Observable namespace was not affected; ontology/uco/observable/catalog-v001.xml already notes that the Pattern namespace is in the transitive import closure.

The impact of this proposal is reduced back to being addition of a single triple, so it is now being treated the bugfix review workflow, for UCO 2.0.0.