ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
73 stars 34 forks source link

Possible bug - ActionLifecycle is not a subclass of ActionPattern #556

Closed ajnelson-nist closed 5 months ago

ajnelson-nist commented 8 months ago

Bug description

Quoting @sbarnum in [this comment]():

action:ActionLifecycle is currently a subClass of action:Action which is appropriate but it should also be a subClass of action:ActionPattern.

Steps to reproduce

Lines 292--294 of 1.2.0's action.ttl seem to confirm the bug description:

    rdfs:subClassOf action:Action ;
    rdfs:label "ActionLifecycle"@en ;
    rdfs:comment "An action lifecycle is an action pattern consisting of an ordered set of multiple actions or subordinate action lifecycles."@en ;

Coordination

ajnelson-nist commented 8 months ago

I think as a structural change, this would be backwards-incompatible and would need to target UCO 2.0.0.

ajnelson-nist commented 5 months ago

From discussion on today's call, we believe the subclassing should be added/restored.

ajnelson-nist commented 5 months ago

I intend to process this as a bugfix proposal, not requiring a Solutions Approval vote. If there are any objections, please post them here before Monday, 2024-01-22.

ajnelson-nist commented 5 months ago

Clarification: This will be a bugfix Pull Request against the develop-2.0.0 branch.