ucoProject / UCO

This repository is for development of the Unified Cyber Ontology.
Apache License 2.0
73 stars 34 forks source link

Should Disk be a subclass of Device? #612

Open ajnelson-nist opened 1 week ago

ajnelson-nist commented 1 week ago

Bug description

The definition of observable:Disk currently reads:

A disk is a storage mechanism where data is recorded by various electronic, magnetic, optical, or mechanical changes to a surface layer of one or more rotating disks.

This reads to me like Disk should be a subclass of observable:Device, but it currently isn't. Its encoded superclass is observable:ObservableObject, here. Was this an oversight?

Steps to reproduce

The tree of Device's subclasses can be seen here, after typing "device" into the filter box.

https://ontology.unifiedcyberontology.org/documentation/entities-tree-classes.html

Suggested resolution

For UCO 2.0.0, change parent class to observable:Device.

For UCO 1.x.0, add a warning-severity shape for disk nodes that they should also be annotated observable:Device. Cut this shape in UCO 2.0.0. This is as was done recently for AlternateDataStream shifting to under FileSystemObject in Issue 590.