ucphhpc / docker-migrid

Containerized MiG
GNU General Public License v2.0
3 stars 7 forks source link

Match check against pattern attributes #2

Closed rasmunk closed 4 years ago

rasmunk commented 5 years ago

https://github.com/rasmunk/docker-migrid/blob/9b8b092f1eb1d7117088a19fe8e0a48bd740fcd4/mig/shared/workflows.py#L1950

Does the match check not work if you include every attribute you wan't to check against? i.e. (input_file, trigger_paths, outputs, recipes, variables).

`# TODO apply this to pattern as well

need to still check variables as they might not match exactly

clients_patterns = get_wp_with(
    configuration, client_id=client_id, first=False, owner=client_id,
    trigger_paths=pattern['trigger_paths'], output=pattern['output'],
    vgrids=pattern['vgrids'])

_logger.debug('clients_patterns: ' + str(clients_patterns))
_logger.debug('pattern: ' + str(pattern))

for client_pattern in clients_patterns:
    pattern_matches = True
    try:
        if client_pattern['input_file'] != pattern['input_file']:
            pattern_matches = False
        if client_pattern['trigger_paths'] != pattern['trigger_paths']:
            pattern_matches = False
        if client_pattern['outputs'] != pattern['outputs']:
            pattern_matches = False
        if client_pattern['recipes'] != pattern['recipes']:
            pattern_matches = False
        if client_pattern['variables'] != pattern['variables']:
            pattern_matches = False`
rasmunk commented 4 years ago

As per the refactor this is no longer an issue