ucphhpc / docker-migrid

Containerized MiG
GNU General Public License v2.0
3 stars 7 forks source link

Feature: added CI pipeline #22

Closed benibr closed 11 months ago

benibr commented 11 months ago

This PR adds a basic Github Action to build and run the default container.

This is useful to test future changes to this repository and the tests from #21 could also be added.

I decided to use Github Actions because it's free to use and doesn't require any external infrastructure.

benibr commented 11 months ago

Not sure why the pipeline is not run for this PR, maybe permissions are missing.

I tested it in my fork: https://github.com/benibr/docker-migrid/actions

benibr commented 11 months ago

I also like to ask if the 1.gocd.yml is still in use? If not we could remove/replace it with Github Actions.

rasmunk commented 11 months ago

I also like to ask if the 1.gocd.yml is still in use? If not we could remove/replace it with Github Actions.

For me, I would prefer it that we don't remove 1.gocd.yml, since I still use it to build test and deploy image versions @ https://ci.erda.dk and would likely also do so in the future :)) I won't mess with the master/latest editions, but it is nice to have when testing future dev branch builds.

benibr commented 11 months ago

I also like to ask if the 1.gocd.yml is still in use? If not we could remove/replace it with Github Actions.

For me, I would prefer it that we don't remove 1.gocd.yml, since I still use it to build test and deploy image versions @ https://ci.erda.dk and would likely also do so in the future :)) I won't mess with the master/latest editions, but it is nice to have when testing future dev branch builds.

Of course if it's still in use, it should stay. Thanks for the info.

jonasbardino commented 11 months ago

Nice, merged