search

ucphhpc / docker-migrid

Containerized MiG
GNU General Public License v2.0
3 stars 7 forks source link

Don't launch the entire stack on a regular make call #34

Closed rasmunk closed 9 months ago

rasmunk commented 9 months ago

I would prefer it, if we would not launch the stack on a regular make call.

To me, I would assume that make simply builds and prepares the stack for launching. Whereas launching/deploying it would be a separate active call, such as make up if the Makefile supports that.

Any objections to this? :)

jonasbardino commented 9 months ago

I'm in favor of this change. Separate launching makes sense to me and shouldn't be a problem when you can just use make up instead of make. Any objections @benibr?

benibr commented 9 months ago

I don't have any objections. In Ansible the dockerbuild target gets called so I thought for local development it makes sense to run just one command to get MiGrid up and running. But I don't rely on it at all. I'd like the idea of a make up/down

benibr commented 9 months ago

Although it might be good to mention make up in the docs in https://docker-migrid.readthedocs.io/en/latest/sections/getting-started/building.html