ucphhpc / docker-migrid

Containerized MiG
GNU General Public License v2.0
3 stars 7 forks source link

Adds the ability to specify which upstream container image registry should be used #70

Closed rasmunk closed 1 month ago

rasmunk commented 1 month ago

This introduces the CONTAINER_REGISTRY variable that can be used to specify which upstream container image registry to use when deploying/building/pushing the docker-migrid stack. This variable can be specified either through the linked environment file, or as an argument when calling make. It defaults to the DockerHub container registry, namely docker.io.

In addition, it also does a bit of format correction to comply with https://docs.docker.com/reference/build-checks/from-as-casing/ to use consistent casing in the FROM --platform statements and thereby remove the build warnings that they throw.

Furthermore, it renames the ARGS variable for the dockerbuild make target to BUILD_ARGS to make it more explicit which target it can be used for.