search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
4 stars 4 forks source link

Apply Python 3 changes to grid_openid allowing test instantiation. #106

Open albu-diku opened 3 months ago

albu-diku commented 3 months ago

Make use of a need to cover the basic operation of this code for some minimal changes that allow the server it implements to be trivial to instantiate directly as an object. Use this ability to do so under test and add the necessary wiring to issue a single top-level request from the server and validate it responds with no internal issues logged.

Note that a top-level request was not previously succeeding due to certain values being errantly dereferenced (though the code was clearly written to have been safe under these circumstances). Fix this here.

jonasbardino commented 3 months ago

Added the OpenID Connect milestone because unit test coverage of the old OpenID 2.0 service is important in the development of the replacement.

albu-diku commented 3 months ago

Added the OpenID Connect milestone because unit test coverage of the old OpenID 2.0 service is important in the development of the replacement.

Thanks - that was definitely the reason to do this, and I remember mentionig directly, but doing this predated the tracking issue hence not being listed there already. No time like the present to start and appreciate your adding it.