ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 4 forks source link

Download files fail #11

Closed ARiis-63 closed 1 year ago

ARiis-63 commented 1 year ago

download files from browser fails for .jpg, .xlsx, .pdf does fail. A blank window opens and nothing else.

mig.log has "2023-04-12 11:53:34,973 ERROR cat: failed on 'Testfil.xlsx': 'utf-8' codec can't decode byte 0x9a in position 15: invalid start byte"

{"deploy_version": "v1.3", "MIG_GIT_REV": "00191118109bbd1013600e810cf256d5190c4d23", "MIG_SVN_REV": "5664"}

Details sent by mail.

jonasbardino commented 1 year ago

Thanks for reporting it, Anders. AFAICT this is the text encoding bug on python 3 with cat.py, which we previously discussed on another channel. The temporary workaround for that is to change max_stream_size = 64*1024*1024; to max_stream_size = 0; in ~mig/mig/images/js/jquery.filemanager.js

jonasbardino commented 1 year ago

A similar workaround is implemented in versions from svn r5691 git master 964c259aae8f5deea236413633372ec66ad760bd git edge 80f2eaffce8447b12e56f4ee2f4919a93b7a3a3f git experimental 396f65f1273999e872e944bbdf250b39900f0137

That should do for this case until we fix the underlying issue.

jonasbardino commented 1 year ago

It was indeed the same problem and both are fixed in experimental revision da49d49f3f59d77b6bcf4cd9b5f423125c9acb08 by handling binary output as such in py3. It should be safe to revert the workaround with that or newer revisions.