search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
4 stars 4 forks source link

Ensure that options set on a configuration instance remain isolated. #125

Closed albu-diku closed 1 month ago

jonasbardino commented 1 month ago

I've added the follow-up tag specifically to remind us that we would probably want to add further configuration unit tests to actually juggle some real configurations and making sure everything works there as well. Including on reload, etc.

albu-diku commented 1 month ago

I've added the follow-up tag specifically to remind us that we would probably want to add further configuration unit tests to actually juggle some real configurations and making sure everything works there as well. Including on reload, etc.

No disagreement here - this was knowingly the least I could do to make sure nothing disastrous had happened but allow me to move forward with the work that needed doing itself under test.

Please note there have been other configuration related PRs open for some time that were intended specifically to tighten configuration related things up further, and the assertion covering the contents of a new configuration object is providing meaningful additional coverage here.

jonasbardino commented 1 month ago

Merged through svn with only a couple of unused imports removed and minor autopep8 adjustments.