ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 4 forks source link

addfreezedata - Stalling due to non-existant file #24

Closed SebastianPrehn closed 11 months ago

SebastianPrehn commented 1 year ago

When using Schedule Tasks, if the user tries to add a file to a Frozen Archive of their choice, and that file does not exist, it causes the archive to end up in a constant state of UPDATING.

___CREATE FREEZE ARCHIVE___
** Error creating/updating archive: Error copying file to archive **
)
2023-09-08 14:25:09,340 INFO ran command: addfreezedata archive-4IHojd testerfile.txt
2023-09-08 14:31:01,062 INFO handle ['addfreezedata', 'archive-4IHojd', 'testerfile2.txt'] for REDACTEDUSERINFO
2023-09-08 14:31:01,063 INFO expanded argument archive-4IHojd to archive-4IHojd
2023-09-08 14:31:01,064 INFO expanded argument testerfile2.txt to testerfile2.txt
2023-09-08 14:31:03,787 INFO ran command: addfreezedata archive-4IHojd testerfile2.txt
2023-09-08 14:33:00,267 INFO handle ['addfreezedata', 'archive-4IHojd', 'nonexistentfile.txt'] for REDACTEDUSERINFO
2023-09-08 14:33:00,268 INFO expanded argument archive-4IHojd to archive-4IHojd
2023-09-08 14:33:00,269 INFO expanded argument nonexistentfile.txt to nonexistentfile.txt
2023-09-08 14:33:02,710 ERROR failed to run command: addfreezedata archive-4IHojd nonexistentfile.txt (command error: Exit code: 200 Description SYSTEM_ERROR (no timing information)
Title: Create Archive

___CREATE FREEZE ARCHIVE___

** Error creating/updating archive: Error copying file to archive **
)

Screenshot 2023-09-08 at 14 54 08

jonasbardino commented 1 year ago

Thanks for reporting it @SebastianPrehn. As a side note we should also check if the same issue arises if one creates an Archive interactively adding a no-longer existing file there. I.e. create Archive, add a file from home, rename/delete same file in another tab, then save.

SebastianPrehn commented 1 year ago

Screenshot 2023-09-11 at 13 17 38

If adding a file via the interactive menu, then going to another tab to delete it, before hitting finalize on the first tab, it produces the error shown above. Additionally, it still makes the archive go into UPDATING mode and locks you out of editing, as shown in the two below screenshots.

Screenshot 2023-09-11 at 13 18 18

Screenshot 2023-09-11 at 13 19 05

jonasbardino commented 11 months ago

For the record interactive Archive add a file, which is then deleted before saving results in a copy error with no Archive created. This is less bad than the stuck in UPDATING case, but should still result in a more telling error message.

jonasbardino commented 11 months ago

This should be fixed in svn rev 5862 and the corresponding git versions. @SebastianPrehn let me know if you want to help verify on one of our development sites before it reaches production.