search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

Update accountreq.py #29

Closed aputtu closed 7 months ago

aputtu commented 9 months ago

Minor text change suggestions for help text in sign up form.

jonasbardino commented 9 months ago

Thanks, but the suggested change probably needs to be very carefully synced with sites where we hit the conditional

    elif configuration.site_peers_mandatory:
        comment_add = ' AND the name + email of your peer contact(s) %(peers_contact_hint)s'
        ...

So that the __COMMENT_ADD__ part is replaced with the above comment_add string.

Speaking of which, I'm surprised to see that SIF external user sign up apparently doesn't end there, even though I think it used to and still should, if it can't support explicit Peers fields due to V2. As it is it neither has the explicit Peers fields nor requires Comment to be filled. Can you confirm and perhaps explain if that is on purpose @Martin-Rehr ? It may or may not be related to the work on reset pw where the same page is (ab)used and the recent long due full upgrade.