search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

added DeiC theme #41

Closed benibr closed 2 months ago

benibr commented 2 months ago

This is just a placeholder theme for DeiC storage which has been copied from ucph-science.

Right now it would make things simpler for me if we could merge this upstream. Later we can either overwrite it with the actual theming files provided by DeiC or remove it again and use Docker volumes overrides to mount it in production. But before we need to further simplify the Docker setup at KU.

jonasbardino commented 2 months ago

I'll merge it as previously agreed but I just wanted to give you a chance to address the comments here first - please let us know if you'd prefer to run a 2nd PR later to do that.

benibr commented 2 months ago

Yeah, this was just a very rough search&replace "skin" and not of good quality %) Thanks for looking though, I corrected all the mentioned points.

jonasbardino commented 2 months ago

Yeah, I figured it was to get the ball rolling, which was good. I've merged now.

jonasbardino commented 2 months ago

Just FYI I backported these skin parts to the other branches to limit divergence.