ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

Support list-form values from OpenID Connect sign up #49

Closed jonasbardino closed 1 month ago

jonasbardino commented 1 month ago

We have seen e.g. WAYF OpenID Connect return a list of email addresses during signup (autocreate.py) and should handle such cases in a proper way instead of just refusing them in input validation. The form appears to be comma-separated list like abc@some.org,def@other.org. We already accept multiple individual email addresses as arguments, so we can probably just split on comma and mimic that. While at it we also need to revisit which one to use as the primary email in that case. For multi values we currently use the last, which may be counter intuitive.

jonasbardino commented 1 month ago

Implemented in https://github.com/ucphhpc/migrid-sync/commit/1aa9d03b05639dc596b5039632d900678131fbf9 and tested to resolve the problem for AU user with two email addresses.