search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

Document classes in the test support module. #55

Closed albu-diku closed 1 month ago

jonasbardino commented 1 month ago

Thanks, manually merged through svn. Only difference is newline added at end of multiline docstrings in line with PEP8: https://peps.python.org/pep-0008/#documentation-strings

albu-diku commented 1 month ago

Thanks, manually merged through svn. Only difference is newline added at end of multiline docstrings in line with PEP8: https://peps.python.org/pep-0008/#documentation-strings

In this case I copied a docstring from another module in the tree, so I guess the rule ins't universally applied. I hadn't wired running stuff through autopep8 automatically at the point I submitted this, but will again raise that it would be nice to take whatever are the common agreed standards and get that applied to the tree "once and for all".

jonasbardino commented 1 month ago

Alright, we're probably not consistent when it comes to old modules, because we started using autotpep8 late. Applying to all existing code would be nice, but in rare cases autopep8 actually breaks stuff, e.g. when it rearranges imports mixed with sys.path mangling as you may have seen try/except-wrapping comments about. So we haven't ventured there, but I principally agree that we should.