search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

WIP: test/mig.shared.localfile #57

Closed albu-diku closed 1 month ago

albu-diku commented 1 month ago

Start putting together LocalFile tests and focus first on locking.

jonasbardino commented 1 month ago

While coverage is always good, please don't spend too much time on localfile or the other localX and distX. They're hardly used anymore if at all and should probably either be retired or completely rewritten based on the catch-all shared.fileio. The same applies for iobase I think, but you can check e.g. with the codegrep.py helper or regular grep.

Good targets for unit testing from mig.shared include base, safeinput, serial, userdb, configuration, logger and validstring for starters. After those I think the accountstate, pwcrypto, vgrid, vgridaccess and perhaps the entire griddaemons subdir may be nice continuation targets to look into.

albu-diku commented 4 weeks ago

Replaced by https://github.com/ucphhpc/migrid-sync/pull/66.