search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

Integrate autopep8 into the Makefile and set default baseline options. #63

Open albu-diku opened 4 weeks ago

albu-diku commented 4 weeks ago

We are currently in a situation of wanting to make sure that out codebase is autopep8 clean but there is no "standardised" way of ensuing this. Take the opportunity to codify this in a new make fmt target - arrange the autopep8 dependency as additional local dependency and invoke it via the envhelp infrastructure.

As part of this commit we configure autopep8 with an option to ignore E402 which disables the re-arrangement of imports - this is relevant to us as we carefully arrange import order and the current workaround (wrapping an extra try-except around the imports with a comment that says its to trick autopep8) is pretty messy in terms of the source code.

jonasbardino commented 3 weeks ago

Manually merged through svn. Not completely sure how it's intended to be used, but it doesn't hurt. I get make errors on make test ; make fmt with or without path args.

jonasbardino commented 1 week ago

@albu-diku please let me know if I can close this one or if it needs further work regarding my previous comment.