ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 4 forks source link

multi line log entry in davs.log #7

Open Bjarke42 opened 1 year ago

Bjarke42 commented 1 year ago

In the davs.log there is a line entry that spans multiple lines

2023-02-17 07:20:45,309 INFO You can create a suitable dhparams file with:
openssl dhparam 2048 -out /etc/httpd/MiG-certificates/dhparams.pem

Please fix this to only be on one line with the correct format, so that we can use automation on the log files.

Also found in ftps.log, openid.log

And another one

2023-08-18 12:58:20,054 ERROR PUT: byte copy failed
Traceback (most recent call last):
...

another one

2023-08-18 11:55:25,066 ERROR Caught HTTPRequestException(HTTP_INTERNAL_ERROR)

Another one

2023-08-10 13:34:13,307 ERROR Traceback (most recent call last):

Even better would ofcause not to print these out if they server no purpose besides debugging on a test setup

jonasbardino commented 1 year ago

Thanks for the report. On a side note I wonder why you get that log at all. Is dhparams.pem missing or hidden by overlays in your (docker-migrid) setup?

Bjarke42 commented 1 year ago

dhparams.pem is missing the first time we are running the installation, after the make and a docker-compose up, we copy it from your certificate directory

jonasbardino commented 1 year ago

Alright, sounds like shadowing to me. If so you might as well mimic the Dockerfile action in your own cert dir:

Dockerfile.rocky8:RUN curl https://ssl-config.mozilla.org/ffdhe4096.txt -o $CERT_DIR/dhparams.pem
Dockerfile.rocky8:    && ln -s $CERT_DIR/dhparams.pem dhparams.pem

as a workaround for now.

There's a bit of explanation behind using these pre-generated dhparams in https://security.stackexchange.com/questions/213163/why-do-predefined-ffdhe-parameters-containt/213168

Bjarke42 commented 11 months ago

Updated with more stuff that genereate multi line log entries