search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 3 forks source link

Fine-grained control over user permission to automatically sign up #76

Closed jonasbardino closed 11 hours ago

jonasbardino commented 1 week ago

Implement fine-grained control over the permission of users to sign up using e.g. autocreate when the corresponding auto_add_X_user setting is enabled. Offers regex filtering on individual user ID fields as manually submitted by user or forwarded by the ID provider of the user when external authentication sources are enabled. This is particularly useful if the ID provider has a huge user base and only some of them should be able to sign up without operator approval.

jonasbardino commented 1 day ago

Thanks for the review with good points @albu-diku . I'll proceed with the merge and leave it for a follow-up PR to do the actual refactoring of those shared regular expression pairs parser helper either in configuration itself or in mig.shared.base. The args can probably be changed to use keyword_auto values by default in the same go.

I see both pros and cons of compiling regex values right away. It would help sanity check but also add a little delay everywhere and potential bogus errors to the config parsing where the values are not even used because e.g. the matching enable_X is False.

jonasbardino commented 11 hours ago

Manually merged through svn