jonasbardino
commented
1 month ago Looks good with one pending question and some pending style polish, including a bit overlap with previous PR comments.
A make test from distclean state gives me a single error:
running with MIG_ENV='local' under python 3
...........sss.....sss..........F..
======================================================================
FAIL: test_existing_main (test_mig_unittest_testcore.MigUnittestTestcore)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/jonas/ku/migrid-sync/migrid-pr76/mig/unittest/testcore.py", line 56, in _assert_local_config
configdir_stat = os.stat(_LOCAL_CONF_DIR)
FileNotFoundError: [Errno 2] No such file or directory: '/home/jonas/ku/migrid-sync/migrid-pr76/envhelp/output/testconfs-py3'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/jonas/ku/migrid-sync/migrid-pr76/tests/test_mig_unittest_testcore.py", line 51, in test_existing_main
testcore_main(_exit=raise_on_error_exit)
File "/home/jonas/ku/migrid-sync/migrid-pr76/mig/unittest/testcore.py", line 91, in main
config = _assert_local_config()
File "/home/jonas/ku/migrid-sync/migrid-pr76/mig/unittest/testcore.py", line 65, in _assert_local_config
raise AssertionError('local configuration invalid or missing: %s' % (str(exc),))
AssertionError: local configuration invalid or missing: [Errno 2] No such file or directory: '/home/jonas/ku/migrid-sync/migrid-pr76/envhelp/output/testconfs-py3'
----------------------------------------------------------------------
Ran 35 tests in 0.213s
FAILED (failures=1, skipped=6)
make: *** [Makefile:44: test] Error 1Just adding the dir and retrying results in further errors (`KeyError: 'GLOBAL' etc.), so I better leave that to you.
albu-diku
Arrange environment specific test configurations such that codepaths that depend upon it (i.e call the get_configuration_object() function) can be used under test. Do this by providing an explicit config making facility as part of the enviromnent helpers which operates based on an environment name e.g. "local" and "test".
For cross-version support the test configuration must be adapted for differences in paths (specifically Python 2 where execution occurs within a container and thus container-relative paths are necessary). Support a --python2 command line argument in makeconfig which causes the paths adjusted as necessary.
Add a wrapper to utilise the pre-existing testcore unit tests as part of the automatde test suite. This is done in order to exercise some codepaths that depend on a valid configuration object. Note though that this approach can likely be used as an examplar of the wrapping necessary to expose existing tests.