search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 4 forks source link

Work the WSGI handlers into a devserver. **PREVIEW** #79

Open albu-diku opened 3 months ago

jonasbardino commented 3 months ago

A few early comments and input suggestions to use at your leisure :-)

It would be nice if devserver would take optional IP and port args for the network binding. Maybe default to localhost / 127.0.0.1 rather than 0.0.0.0 to follow a secure by default approach.

PEP8 stipulates to put stdlib imports before 3rd party libs like cheroot (https://peps.python.org/pep-0008/#imports). Similarly I'd argue that application_ should be _application the way I read PEP8 (https://peps.python.org/pep-0008/#descriptive-naming-styles).

I'd prefer Exception as e: to be Exception as exc: in line with our previous discussion about single letter vars.