search

ucphhpc / migrid-sync

MiGrid workspace where master branch is kept strictly in sync with SF upstream svn repo. Any development or experiments should use a branch. You probably want to fork your own clone or work e.g. on the edge branch if you wish to contribute.
GNU General Public License v2.0
3 stars 4 forks source link

Make the force recursive functions work on Python 3. #93

Open albu-diku opened 1 month ago

albu-diku commented 1 month ago
albu-diku commented 3 weeks ago

While there's definitely some general progress and valuable unit tests here I think it needs another round of adjustments to be correct and 'complete'. Do you feel like giving it another go or should I perhaps wrap up my comments+suggestions in another PR for you to inspect?

Given it another go after discussion in-person. What we arrived at is treating the data structure walker more generically and simply passing it the function to use for evaluating whether it encountered a primitive - this actually fits much better with what it already did with _force_primitive.

Of futher note is that this PR is more like a deduplication of the walking logic at this point, mostly after noticing that it had ended up unintentionally doing two separate things - fixing tuples and refactoring the logic. The former is better done as the minimal thing required in migwsgi coverage (which is what this spun out from) and in doing so makes the two PRs independent.