ucr-riple / NullAwayAnnotator

A tool to help adapting code bases to NullAway type system.
MIT License
13 stars 6 forks source link

Refactor Change#visit method in injector module #165

Closed nimakarimipour closed 1 year ago

nimakarimipour commented 1 year ago

This PR updates the method below:

Modification visit(NodeWithAnnotations<?> node, Range range)

To

<T extends NodeWithAnnotations<?> & NodeWithRange<?>> Modification visit(T node)

Since the value for range is retrievable from the class implementing NodeWithAnnotations, all calls to this method were as below:

visit(node, node.getRange)

With this update, all calls are changed to simply:

visit(node)
nimakarimipour commented 1 year ago

Fancy :-)

@msridhar Thank you very much for the review, landed it. 🙂.