search

ucr-riple / NullAwayAnnotator

A tool to help adapting code bases to NullAway type system.
MIT License
13 stars 6 forks source link

Collect std out using Redirect.INHERIT API #206

Closed nimakarimipour closed 1 year ago

nimakarimipour commented 1 year ago

Resolves #205. This PR refactors std error output collection by using Redirect.INHERIT API. It also adds collecting std out of the child process (module builds) and prints them along the std error if -rboserr is set.

msridhar commented 1 year ago

Do we have any regression tests for this, or have you been able to test manually?

nimakarimipour commented 1 year ago

Do we have any regression tests for this, or have you been able to test manually?

@msridhar We don't have a regression test for this. But I just tested it manually and can see the std output and error when the flag is enabled.