search

ucrcsedept / galah

An automated grading system geared towards processing computer programming assignments.
Apache License 2.0
42 stars 8 forks source link

should choose latest of personal and overall deadlines? #388

Closed atkoehler closed 10 years ago

atkoehler commented 10 years ago

The modify_assignment command can change the deadline and cutoff date. However, so does the modify_user_deadline command. These don't play nice together.

It appears that if a personal deadline is set, the web interface will not allow submission and testing no matter what the overall deadlines are for the assignment. Meaning that the personal deadline is taking precedence. This sort of makes some sense but I think it logically makes more sense to utilize the later of the two. Or an even better solution would be: if an overall assignment deadline change occurs to clear all personal deadlines that are before it.

Example causing problem:

  1. Create the assignment and set the deadlines, say 11/15
  2. One user has problems so you use modify_user_deadline to set the personal deadlines to 11/16. This allows the individual to turn in until 11/16.
  3. A lot more students are having problems so you decide to extend the entire assignment 2 days. Use modify_assignment to set 11/17.
  4. Despite the assignment being due 11/17 now, the one user's submission is only allowed until 11/16
itsjohncs commented 10 years ago

What if we just allowed you to look through who as a per-user deadline associated with them? I'm worried about making it pick the later of the two because it's conceivable that a teacher would want to make a deadline for a particular student before the deadline for everyone else.

atkoehler commented 10 years ago

Is there a command to reset per user deadlines? I couldn't think of one although I didn't look through the api. I could not determine how to reset it to not existent so that the overall one is utilized.

itsjohncs commented 10 years ago

There is no such way to do that right now. So it looks like implementing the two following features would resolve this issue:

Is this correct?

atkoehler commented 10 years ago

yes that would be helpful.

the reset could easily be a bulk reset or a user specific reset

bulk:

reset_user_deadlines Dummy/cs10

individual user:

reset_user_deadlines Dummy/cs10 user@email.fake
paranoiacblack commented 10 years ago

Added reset_user_deadlines and view_user_deadlines with the functionality suggested by @atkoehler. I'll leave it to you to close this issue.

itsjohncs commented 10 years ago

Looks good to me :+1: