ucsb-cs-course-repos / course-repo-jekyll-theme

A Jekyll Theme for course repos
1 stars 2 forks source link

Add collapse-card-begin, collapse-card-end; support for main_extra in _data/navigation.yml; fix some broken css; location of js files more consistent #8

Closed pconrad closed 5 years ago

pconrad commented 5 years ago

(1) Add collapse-card-begin and collapse-card-end to the _includes directory. This allows us to DRY up a bit of the code in index.md files across the various repos for making cards that have a dropdown button.

(2) Course level repos can now have extra navigation links using a list of links under the main_extra key in _data/navigation.yml

(3) There was some CSS that was broken that was making table borders appear inconsistent

(4) Some JavaScript files were in _includes instead of assets/js.

Except in the case of nav-json.js, there is no reason for that.

So we've consolidated all js files under assets/js.

For nav-json.js, we wanted to have a variable nav that locally (in head_scripts.js) is assigned to the same value as the object returned via json for ajax calls to /assets/js/nav-json.js

Note that nav-json.js is, as yet, unused. It is the beginning of an experiment to try to do the offering parts of navigation menus in course level repos via json. If that ends up being a dead end, or implemented another way, nav-json.js should be eliminated.