ucsb-cs156-f23 / proj-happycows-f23-5pm-1

https://ucsb-cs156-f23.github.io/proj-happycows-f23-5pm-1/
0 stars 0 forks source link

lli - Added UI changes and tests for Instructor Report Page #20

Closed lukewli closed 11 months ago

lukewli commented 11 months ago

Overview

In this PR, I have made changes to the Instructor Report Page UI so that the values for fields like Num Cows, Cows bought, etc, are right-justified and the Total Wealth field is now formatted as currency.

Screenshots

Before

Screenshot 2023-11-20 at 2 45 56 PM Screenshot 2023-11-20 at 5 29 38 PM

After

Screenshot 2023-11-20 at 5 29 42 PM Screenshot 2023-11-20 at 5 32 23 PM

Validation

  1. Download this branch and run the project.
  2. Login for admin access and create/join a commons.
  3. Create an instructor report for the common you've joined from the manage jobs page.
  4. Check that the numbers are right-justified and that total wealth is formatted as a currency.

Tests

Linked Issues

Closes #14

lukewli commented 11 months ago

Sure thing. I'll make changes to the other part of the report in this PR. Should I also right-justify the "id" field or leave that one as is?

haroldmo commented 11 months ago

this looks good.