search

ucsb-cs156-m23 / proj-gauchoride-m23-9am-3

https://ucsb-cs156-m23.github.io/proj-gauchoride-m23-9am-3/
0 stars 0 forks source link

Implemented Shift Pages (Create, Edit and Index) #31

Closed lawrencewang30 closed 1 year ago

lawrencewang30 commented 1 year ago

Implemented Pages for Shift, Create and Edit pages both passed 100% mutation coverage and local tests. Put create shift page under dropdown title "Shift", similar to "Ride Request". Also, Driver/Rider homepage will be different than Admin's since they do not have access to creating shifts/rides

My dokku dev link: https://proj-gauchoride-lawrence.dokku-03.cs.ucsb.edu

Create Shift: image

Update Shift: image

Table of Shifts: image

Closes #29, closes #32, closes #33, closes #22

lawrencewang30 commented 1 year ago

Got it, I updated the title of the PR and resolved the merge conflict on my ShiftControllerTest.java file

pconrad commented 1 year ago

If there's time to get @chriscerie 's suggestion in, then great. If not, then we'll make it an issue for the Staff to do as they get the code base ready for F23.

chriscerie commented 1 year ago

@pconrad I realized there are other areas of this same pattern. I'd be fine with them being done in another pr, since that will need to happen regardless.