ucsb-cs156-m23 / proj-gauchoride-m23-9am-3

https://ucsb-cs156-m23.github.io/proj-gauchoride-m23-9am-3/
0 stars 0 forks source link

AW-Implemented RiderApplication Table&Form Component #40

Closed Kanagawa-okiNamiUra closed 1 year ago

Kanagawa-okiNamiUra commented 1 year ago

In this PR, I implemented RiderApplication Table&Form. I also updated currentUserFixture file to include a user that only has the role ROLE_MEMBER (in the original file every one with "ROLE_MEMBER" has "ROLE_ADMIN"). 100% mutation/line coverage.

A few implementation details to note:

  1. Form component:
  1. Table Component:
    • Member's view: image -Cancel Button asks for Confirmation: image -Admin's view: image

For whether the button navigates to the correct URL, please check my testfilles.

Close #42

Kanagawa-okiNamiUra commented 1 year ago

This should conclude Issue 3 and Issue 4 from EPIC#14

Danny-You commented 1 year ago

The author mentions that he might add some more features to this PR, so we will wait for the additional features then starting reviewing by tonight.

Kanagawa-okiNamiUra commented 1 year ago

After discussing with Guy, I realized the notes field should show up in the form when an admin logs in. However, this might require my form function to take in one more parameter currentUser. I’ll work on it later when I attempt the admin page. For now, I’ll keep it as is in this PR as I do not expect any problem when I implement member pages. Please give it a review now.