ucsb-cs156-m23 / proj-gauchoride-m23-9am-3

https://ucsb-cs156-m23.github.io/proj-gauchoride-m23-9am-3/
0 stars 0 forks source link

AW--Implemented Index/Create/Edit Page for Rider Application from Member's View #44

Closed Kanagawa-okiNamiUra closed 1 year ago

Kanagawa-okiNamiUra commented 1 year ago

In this PR, I implemented Index/Create/EditPage for Rider Application from Member's View (in the nav bar "Apply to be a rider." I also added a placeholder nav bar for admin's view.

Notice that this PR does not address not the fourth issue in the instruction because the show page, where fields not disabled in the form should be read only. I could not figure out how to do that other than writing a new Table component, which could be demanding considering the time I had. For now, the show button in the table will lead to the edit page, which is very similar to what it is supposed to look like.

Running Instance at: https://gride-albert-dev.dokku-03.cs.ucsb.edu/

An implementation note is that we (who have both ROLE_ADMIN and ROLE_MEMBER) will only have ROLE_MEMBER when we open the Index page. This is achieved by creating a copy of currentUser and modify the copy for easier reuse of the table component. In reality, it would not be a problem for users and we admins are barely affected. A picture explanation is attached below. image

Some more screenshots of the app: image image

pconrad commented 1 year ago

I think I found a bug in this PR. Can someone on the team take a look?

It doesn't have to be the original PR author. Anyone can take a look at this and try to fix it (or explain why it's not a bug).

Specifically, if you look at App.js on this branch:

https://github.com/ucsb-cs156-m23/proj-gauchoride-m23-9am-3/blob/Albert-RiderApp_III/frontend/src/App.js

There is no mapping for the route /admin/applications/riders

However, the menu option "Rider Applications" in the Navbar links to that URL, which is "not found".

image
Kanagawa-okiNamiUra commented 1 year ago

Thanks for pointing that out. I will implement the Index Page for Rider Application in the next PR.