search

ucsb-cs156-m23 / proj-happycows-m23-10am-4

https://ucsb-cs156-m23.github.io/proj-happycows-m23-10am-4/
0 stars 1 forks source link

Add fixme to fix prop mutation #109

Closed chriscerie closed 1 year ago

chriscerie commented 1 year ago

This adds a fixme to fix the prop mutation introduced in #108. If it stays, it will be a source of bug that will be very difficult to debug.

publicqi commented 1 year ago

I create a new branch. Does this fix? https://github.com/ucsb-cs156-m23/proj-happycows-m23-10am-4/commit/6ba2fe693e7d452bd6bb34bb90ab01a69146997c

chriscerie commented 1 year ago

I create a new branch. Does this fix? 6ba2fe6

Yes thanks for fixing. Make sure to do the null check before shallow copying.

publicqi commented 1 year ago

Please see #110