Closed dscpsyl closed 1 year ago
All changes have been implemented.
@dscpsyl could you update the screen shot to show the right alignment, and also get a peer code review? Then I think I can code review and merge it.
Screenshot updated. Waiting on peer code review
Overview
The react component has been updated to display the total wealth on the leaderboard in currency format. No underlying changes to the data have been made. Only the rendering react table file has been updated.
Screenshots
Feedback Request
This method uses native javascript, so there should be no dependency issues. Please suggest if there are more elegant ways to do this, as this method requires a declaration and making another object. Ideally, it would be a one-liner, maybe some formatting that is native to React instead.
Validation
Tests
ChangeLog
Note: some file changes here are from the previous pull request. As such, they will not be listed here.
frontend/src/main/components/Leaderboard/LeaderboardTable.js
Created a USD currency object to format the total wealth column and updated the table entry to format the raw data into USD.frontend/src/tests/components/Leaderboard/LeaderboardTable.test.js
Tests now look for the USD currency.Linked Issues
Closes #2