ucsb-cs156-m23 / proj-happycows-m23-10am-4

https://ucsb-cs156-m23.github.io/proj-happycows-m23-10am-4/
0 stars 1 forks source link

Leaderboard now shows total wealth in USD currency #17

Closed dscpsyl closed 1 year ago

dscpsyl commented 1 year ago

Overview

The react component has been updated to display the total wealth on the leaderboard in currency format. No underlying changes to the data have been made. Only the rendering react table file has been updated.

Screenshots

Screenshot 2023-08-14 at 4 50 01 PM

Feedback Request

This method uses native javascript, so there should be no dependency issues. Please suggest if there are more elegant ways to do this, as this method requires a declaration and making another object. Ideally, it would be a one-liner, maybe some formatting that is native to React instead.

Validation

  1. Download this branch and run the service locally.
  2. Navigate to the leaderboard page.
  3. You should see the total wealth column be displayed in USD currency format.

Tests

ChangeLog

Note: some file changes here are from the previous pull request. As such, they will not be listed here.

Linked Issues

Closes #2

dscpsyl commented 1 year ago

All changes have been implemented.

pconrad commented 1 year ago

@dscpsyl could you update the screen shot to show the right alignment, and also get a peer code review? Then I think I can code review and merge it.

dscpsyl commented 1 year ago

Screenshot updated. Waiting on peer code review