search

ucsb-cs156-m23 / proj-happycows-m23-10am-4

https://ucsb-cs156-m23.github.io/proj-happycows-m23-10am-4/
0 stars 1 forks source link

Fix schedule timezone bug #64

Closed yuanchenmeng closed 1 year ago

yuanchenmeng commented 1 year ago

Overview

Time zone environmental variable is added in src/main/resources/application.properties

image

zone param is added for scheduled jobs

image

Tests

Backend Test coverage & Mutation tests : 100%

Linked Issues

Previous version of this PR: #41 Closes #4

yuanchenmeng commented 1 year ago

Code changed, requested for CR.

yuanchenmeng commented 1 year ago

Merge conflicts resolved

yuanchenmeng commented 1 year ago

It appears that all of the changes in this PR were already made in a previous PR.... it appears that there are actually no changes here except formatting.

Please let me know if I'm missing something.

If this is obsolete, let's close it.

When I worked for this PR, initially I only changed cron value in schedule.js file. At the same time, Iain worked on schedule.js as well for CommonStats branch. We both agreed to add additional variables into springboot resource file. He made a commit into my PR so that my PR was consistent with his branch, link to the commit: 81ad12c123baf727616c7ed1b0ac97b9bc0fe008. Therefore, the timezone bug is already fixed in Iain's commonStats PR. However, as we addressed different issues in this case, I wonder if we can get points for this PR or just close it.

pconrad commented 1 year ago

It appears that all of the changes in this PR were already made in a previous PR.... it appears that there are actually no changes here except formatting. Please let me know if I'm missing something. If this is obsolete, let's close it.

When I worked for this PR, initially I only changed cron value in schedule.js file. At the same time, Iain worked on schedule.js as well for CommonStats branch. We both agreed to add additional variables into springboot resource file. He made a commit into my PR so that my PR was consistent with his branch, link to the commit: 81ad12c. Therefore, the timezone bug is already fixed in Iain's commonStats PR. However, as we addressed different issues in this case, I wonder if we can get points for this PR or just close it.

No.. there's literally no new functionality here. It's exactly the same code, as far as I can see, just reformatted.

In any case, the team already has so many points that I don't think it's going to be a big deal. I'm going to just close this one.