Chat Message Backend API

ucsb-cs156-m23 / proj-happycows-m23-10am-4

https://ucsb-cs156-m23.github.io/proj-happycows-m23-10am-4/

0 stars 1 forks source link

Chat Message Backend API #76

Closed dscpsyl closed 1 year ago

dscpsyl commented 1 year ago

Overview

In this PR, we fully implement the chat API backend, complete with user and admin get/post/put as specified in #1. This is an extension of PR #68 and thus has been merged into one. The comments and questions from that PR still stand and should be discussed. Refer to #68 for more details.

Tests

[x] Backend Unit tests (mvn test) pass
[x] Backend Test coverage (mvn test jacoco:report) 100%
[x] Backend Mutation tests (mvn test pitest:mutationCoverage) 100%

Linked Issues

Closes #46 Closes #71

iain801 commented 1 year ago

Also, the GET methods always return nothing for the content. I would prefer if the /api/chat/get/all endpoint still existed and only took in the commonsId.

dscpsyl commented 1 year ago

@iain801 Unfortunately, the specifications require that all returns are pagable. I modeled it after jobs if you want to reference and see how that is implemented. Please make sure that the first page you're requesting is 0. As of writing this, the qa deployment has my branch if you would like to test out swagger on it. If you're still having issues, let me know!

iain801 commented 1 year ago

Actually, I will create a new PR tomorrow that will encompass all the backend and frontend MVP, so that the tree and merging is simpler for TA's

iain801 commented 1 year ago

And the page 0 will have the most recent messages?