ucsb-cs156-s21 / proj-ucsb-cs-las

https://proj-ucsb-cs-las.herokuapp.com/
MIT License
2 stars 3 forks source link

6pm 3 quarter filter- in quarter filter page, can only search courses using correct quarter format (e.g 'W21') #147

Closed pranav01acharya closed 3 years ago

pranav01acharya commented 3 years ago

Fixes #121 . Now, admin can search courses by quarter in the quarter filter page using only the correct format (eg 'W21') and not any other format (eg '20211').

codecov[bot] commented 3 years ago

Codecov Report

Merging #147 (329544b) into main (9ddacd5) will decrease coverage by 0.39%. The diff coverage is 85.71%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main     #147      +/-   ##
=============================================
- Coverage     100.00%   99.60%   -0.40%     
- Complexity       328      333       +5     
=============================================
  Files             78       78              
  Lines           1493     1528      +35     
  Branches          69       76       +7     
=============================================
+ Hits            1493     1522      +29     
- Misses             0        3       +3     
- Partials           0        3       +3     
Impacted Files Coverage Δ Complexity Δ
javascript/src/main/pages/Admin/QuarterFilter.js 100.00% <ø> (ø) 0.00 <0.00> (ø)
...u/ucsb/ucsbcslas/controllers/CourseController.java 100.00% <ø> (ø) 30.00 <0.00> (ø)
...ucsbcslas/controllers/ActiveQuarterController.java 86.36% <76.92%> (-13.64%) 10.00 <1.00> (+5.00) :arrow_down:
...t/src/main/components/Courses/QuarterFilterForm.js 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...vascript/src/main/services/QuarterFilterService.js 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ddacd5...329544b. Read the comment docs.

pranav01acharya commented 3 years ago

This issue will be opened in another pr