ucsb-cs156-s21 / proj-ucsb-cs-las

https://proj-ucsb-cs-las.herokuapp.com/
MIT License
2 stars 3 forks source link

Danger test (DO NOT MERGE) #226

Closed btk5h closed 3 years ago

github-actions[bot] commented 3 years ago
Fails
:no_entry_sign: It looks like your PR contains changes to the `javascript/package-lock.json` file. You should not be modifying this file unless you are updating the project's dependencies.
Instructions for removing this change from your commit Run the following commands in the base directory of the project: ```sh git checkout origin/main -- javascript/package-lock.json git commit -m "Revert changes to package-lock.json" git push ```
:no_entry_sign: It looks like you've deleted the one of the `.SAMPLE` configuration files. These files are used as templates for setting up the project, so they shouldn't be removed from the repo.
Instructions for removing this change from your commit Run the following commands in the base directory of the project: ```sh git checkout origin/main -- secrets-localhost.properties.SAMPLE secrets-heroku.properties.SAMPLE javascript/.env.local.SAMPLE javascript/.env.production.SAMPLE git commit -m "Revert changes to sample config files" git push ```

Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.

Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.

PR review process

Generated by :no_entry_sign: dangerJS against 14b019118bdee1710b72277351b0c559d907919d

codecov[bot] commented 3 years ago

Codecov Report

Merging #226 (8ea8959) into main (7817a49) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 8ea8959 differs from pull request most recent head 14b0191. Consider uploading reports for the commit 14b0191 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##               main     #226   +/-   ##
=========================================
  Coverage     99.82%   99.82%           
  Complexity      342      342           
=========================================
  Files            83       83           
  Lines          1669     1669           
  Branches         77       77           
=========================================
  Hits           1666     1666           
  Misses            3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7817a49...14b0191. Read the comment docs.