kenny-wang6 commented 3 years ago

In this PR, the team added the feature for editing existing office hours, as well as front-end and back-end testing

github-actions[bot] commented 3 years ago

Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.

Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.

PR review process

Generated by :no_entry_sign: dangerJS against 96123314242985b6fd439cd5b72b53ffe7af51c7

codecov[bot] commented 3 years ago

Codecov Report

Merging #257 (9612331) into main (27faa94) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #257   +/-   ##
=========================================
  Coverage     99.83%   99.83%           
- Complexity      386      390    +4     
=========================================
  Files            86       87    +1     
  Lines          1782     1820   +38     
  Branches         82       85    +3     
=========================================
+ Hits           1779     1817   +38     
  Misses            3        3

Impacted Files	Coverage Δ
javascript/src/main/App.js	`100.00% <ø> (ø)`
.../src/main/components/OfficeHours/OfficeHourForm.js	`100.00% <100.00%> (ø)`
...src/main/components/OfficeHours/OfficeHourTable.js	`100.00% <100.00%> (ø)`
...ript/src/main/pages/OfficeHours/EditOfficeHours.js	`100.00% <100.00%> (ø)`
...src/main/services/OfficeHours/OfficeHourService.js	`100.00% <100.00%> (ø)`
...cslas/controllers/OnlineOfficeHoursController.java	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27faa94...9612331. Read the comment docs.

PureDreamerGk commented 3 years ago

We are still trying to add a test for the office hour table, which verify that the edit button is rendered

kenny-wang6 commented 3 years ago

We are still trying to add a test for the office hour table, which verify that the edit button is rendered

We fixed the issue and now have coverage for all tests.

pconrad commented 3 years ago

There appears to be a bug.

STR:

Create a new office hour on Wednesday

Try to edit it

Desired: When the screen comes up to edit, it should START with Wednesday as the day of the week.

Observed: When the screen comes up, it switches the office hour to Monday whether you like it or not.

Carl and I just working on this, and I think we fixed it. Stay tuned.

ucsb-cs156-s21 / proj-ucsb-cs-las

KW/CX 6pm-1 update office hour #257

Codecov Report