ucsb-cs156-s21 / proj-ucsb-cs-las

https://proj-ucsb-cs-las.herokuapp.com/
MIT License
2 stars 3 forks source link

pc - don't collect coverage information from fixtures #291

Closed pconrad closed 3 years ago

pconrad commented 3 years ago

In this PR, we exclude the javascript/src/fixtures directory from jest test-coverage.

github-actions[bot] commented 3 years ago

Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.

Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.

PR review process

Generated by :no_entry_sign: dangerJS against 106d87b9e28b94a44c3cb024441dcae706acbd27

codecov[bot] commented 3 years ago

Codecov Report

Merging #291 (106d87b) into main (16e4cdf) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #291   +/-   ##
=========================================
  Coverage     99.69%   99.69%           
  Complexity      439      439           
=========================================
  Files           107      107           
  Lines          2304     2304           
  Branches        104      104           
=========================================
  Hits           2297     2297           
  Misses            7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16e4cdf...106d87b. Read the comment docs.

andrewhlu commented 3 years ago

Closing as this was already implemented in #287.