Open noahcorona44 opened 3 years ago
Merging #294 (4243e25) into main (8e5e4aa) will decrease coverage by
0.25%
. The diff coverage is98.55%
.:exclamation: Current head 4243e25 differs from pull request most recent head e989c02. Consider uploading reports for the commit e989c02 to get more accurate results
@@ Coverage Diff @@
## main #294 +/- ##
============================================
- Coverage 99.80% 99.55% -0.26%
+ Complexity 406 388 -18
============================================
Files 99 86 -13
Lines 2076 1783 -293
Branches 97 84 -13
============================================
- Hits 2072 1775 -297
- Misses 4 8 +4
Impacted Files | Coverage Δ | |
---|---|---|
javascript/src/main/App.js | 100.00% <ø> (ø) |
|
...t/src/main/components/Courses/QuarterFilterForm.js | 100.00% <ø> (ø) |
|
javascript/src/main/components/Nav/AppNavbar.js | 100.00% <ø> (ø) |
|
...src/main/components/OfficeHours/OfficeHourTable.js | 100.00% <ø> (ø) |
|
javascript/src/main/pages/Admin/ViewLogins.js | 100.00% <ø> (ø) |
|
...vascript/src/main/pages/OfficeHours/OfficeHours.js | 100.00% <ø> (ø) |
|
...src/main/pages/TutorAssignment/TutorAssignments.js | 100.00% <ø> (ø) |
|
...src/main/services/OfficeHours/OfficeHourService.js | 100.00% <ø> (ø) |
|
...vascript/src/main/services/QuarterFilterService.js | 100.00% <ø> (ø) |
|
...cslas/controllers/OnlineOfficeHoursController.java | 100.00% <ø> (ø) |
|
... and 22 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8e5e4aa...e989c02. Read the comment docs.
Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.
Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.
Generated by :no_entry_sign: dangerJS against e989c025e0126458900ea3170b37d891ee977fb9
This PR got really messy, I'm sorry about that!
I was working on the back end, planning on getting the front end done before submission. Rag and Rowan helped with the front end last night, but the tests weren't done in time. So, the issue was written, an separate issue made for the front end. I also removed the relevant portions of code, and gave the files to Rowan and Rag so they can push them to a new branch. This took a few hours because when I tried to "go back" to when I finished the back end and began the front end, I started getting all sorts of errors I initially was not, and this took until now to get everything fixed. However I believe the back end tests are passing, and the front end code removed.