ucsb-cs156-s21 / proj-ucsb-cs-las

https://proj-ucsb-cs-las.herokuapp.com/
MIT License
2 stars 3 forks source link

6pm 3 office hours selector #297

Closed m-cabello closed 3 years ago

m-cabello commented 3 years ago

In this front end only issue, we create a component called OfficeHoursSelector.

This component accepts an array of OfficeHours in the json format provided by the back end, and it displays that list as a dropdown menu.

It provides a onChange function that will be passed the index of whatever office hours entry was selected.

This can be used on the TutorNotes creation form to select a specific office hours slot

codecov[bot] commented 3 years ago

Codecov Report

Merging #297 (82d9d5e) into main (43c75d8) will decrease coverage by 0.05%. The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #297      +/-   ##
============================================
- Coverage     99.84%   99.79%   -0.06%     
  Complexity      410      410              
============================================
  Files            90       91       +1     
  Lines          1951     1958       +7     
  Branches         94       94              
============================================
+ Hits           1948     1954       +6     
- Misses            3        4       +1     
Impacted Files Coverage Δ
...main/components/OfficeHours/OfficeHoursSelector.js 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43c75d8...82d9d5e. Read the comment docs.

github-actions[bot] commented 3 years ago

Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.

Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.

PR review process

Generated by :no_entry_sign: dangerJS against 82d9d5e1c792705fd183bb0fff1edfb84a485bb7

pconrad commented 3 years ago

Note: I'm allowing this one to go through with some front-end coverage gaps, because I worked with the team for a while to try to resolve those, and we were unsuccessful. We'll make that a separate story.