Closed YuehanLee closed 3 years ago
Fails | |
---|---|
:no_entry_sign: |
It looks like your PR contains changes to the `javascript/package-lock.json` file. You should not be modifying this
file unless you are updating the project's dependencies.
Instructions for removing this change from your commitRun the following commands in the base directory of the project: ```sh git checkout origin/main -- javascript/package-lock.json git commit -m "Revert changes to package-lock.json" git push ``` |
Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.
Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.
Generated by :no_entry_sign: dangerJS against c923fb689b2d179e9d760cd06268539076ea4f01
Merging #310 (c923fb6) into main (abe0144) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #310 +/- ##
=========================================
Coverage 99.75% 99.75%
Complexity 406 406
=========================================
Files 99 99
Lines 2078 2078
Branches 97 97
=========================================
Hits 2073 2073
Misses 5 5
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update abe0144...c923fb6. Read the comment docs.
This updates the "browsers list" for the caniuse-lite npm module, as recommended here, to remove the warning that it is out of date: