rowantran commented 3 years ago

In this PR, we implement a RoomSlotSelector component that accepts an array of room slots, as serialized by the backend, and displays them in a Bootstrap select dropdown. In the future this component can be used to support linking a room slot when creating office hours.

We also include Storybook stories for this component.

Closes #306.

codecov[bot] commented 3 years ago

Codecov Report

Merging #312 (5d49317) into main (b2b0e84) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #312   +/-   ##
=========================================
  Coverage     99.63%   99.64%           
  Complexity      439      439           
=========================================
  Files           101      102    +1     
  Lines          2218     2229   +11     
  Branches        104      104           
=========================================
+ Hits           2210     2221   +11     
  Misses            8        8

Impacted Files	Coverage Δ
.../src/main/components/RoomSlots/RoomSlotSelector.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2b0e84...5d49317. Read the comment docs.

github-actions[bot] commented 3 years ago

Nice PR! Your PR can be merged once you get an approving review from a staff member and a member of your team.

Keep in mind, code reviews only count if you use the "Approve" or "Request changes" option in GitHub. You can find this under the "Files changed" tab under the "Review changes" button.

PR review process

Generated by :no_entry_sign: dangerJS against 5d49317ea6c76fc0066731a9e81891b64d5dfda9

ucsb-cs156-s21 / proj-ucsb-cs-las

6pm-2 room slot selector #312

Codecov Report