EN - Fixed Bug: Made "UCSB Courses Search" button appear clearly as button

ucsb-cs156-s24 / proj-courses-s24-4pm-1

https://ucsb-cs156-s24.github.io/proj-courses-s24-4pm-1/

0 stars 0 forks source link

EN - Fixed Bug: Made "UCSB Courses Search" button appear clearly as button #27

Closed ericknee closed 4 months ago

ericknee commented 4 months ago

Fixes Issue #23
Made "UCSB Courses Search" link on main page Navbar appear clearly as button
Edited AppNavbar.js

Before:

After:

Dokku deployment: https://project-ericknee-dev.dokku-01.cs.ucsb.edu/

pconrad commented 4 months ago

For the Stryker gap:

Two possible solutions:

Factor out the CSS into a section that you can use // Stryker disable all and then // Stryker restore all to exclude
Write a test similar to this one from frontend/src/tests/components/BasicCourseSearch/CourseOverTimeInstructorSearchForm.test.js

    expect(buttonRow).toHaveAttribute(
      "style",
      "padding-top: 10px; padding-bottom: 10px;",
    );

pconrad commented 4 months ago

I've added the FIXME-Stalled label since this PR doesn't seem to be moving forward. The team may want to see if the author needs help getting it moving.